Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Implement 2D CSS transforms per CSS-TRANSFORMS § 5, 6, 7, and 8. #4522

Closed
wants to merge 1 commit into from
Closed

layout: Implement 2D CSS transforms per CSS-TRANSFORMS § 5, 6, 7, and 8. #4522

wants to merge 1 commit into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jan 1, 2015

r? @SimonSapin
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3617

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm jdm added the S-needs-rebase label Jan 8, 2015
@jdm jdm mentioned this pull request Feb 26, 2015
Open
@pcwalton pcwalton force-pushed the pcwalton:transforms branch from 0163343 to 72644ad Mar 3, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Mar 3, 2015

Rebased. r? @SimonSapin
@pcwalton pcwalton removed the S-needs-rebase label Mar 3, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Mar 3, 2015

Review hasn’t started yet, and I’d rather not deal with the rebase in Critic. Could you make a new PR? Perhaps in the shared repo, so that if there are only trivial fixes left before landing I can do them while you sleep.

It also needs a rebase again, likely because of tests/ref/basic.list. Try moving the new lines somewhere random in the middle of the file, rather than at the end. (A proper fix is coming, in #5123.)
@pcwalton
layout: Implement 2D CSS transforms per CSS-TRANSFORMS § 5, 6, 7, and 8.
93e9fb9
@pcwalton pcwalton force-pushed the pcwalton:transforms branch from 72644ad to 93e9fb9 Mar 3, 2015
@pcwalton pcwalton closed this Mar 3, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Mar 3, 2015

Moved to #5134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@pcwalton @hoppipolla-critic-bot @SimonSapin @jdm
You can’t perform that action at this time.