Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Implement `font-stretch` per CSS3-FONTS § 3.3 in the Core Text font backend. #4524

Closed
wants to merge 1 commit into from
Closed

gfx: Implement `font-stretch` per CSS3-FONTS § 3.3 in the Core Text font backend. #4524

wants to merge 1 commit into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jan 1, 2015

r? @glennw
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3622

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
components/gfx/font_template.rs Outdated
italic: italic,
}
}
}

impl PartialEq for FontTemplateDescriptor {

This comment has been minimized.

Sign in to view
Copy link
@glennw

glennw Jan 4, 2015

Member

I don't think you can remove this and replace with PartialEq because the is_bold() method on weight is not an equality check?
@glennw
Copy link
Member

glennw commented Jan 4, 2015

Needs a rebase and fix / comment for the note above.
@pcwalton pcwalton force-pushed the pcwalton:font-stretch branch from a4605ee to 011be71 Jan 7, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 7, 2015

Issue addressed and rebased. r? @glennw (will not land until after rustup)
@pcwalton pcwalton force-pushed the pcwalton:font-stretch branch from 011be71 to f454dcd Jan 8, 2015
@pcwalton pcwalton force-pushed the pcwalton:font-stretch branch from f454dcd to 448a9f5 Jan 28, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 28, 2015

Rebased and updated. r? @glennw
bors-servo pushed a commit that referenced this pull request Jan 28, 2015
bors-servo
auto merge of #4524 : pcwalton/servo/font-stretch, r=glennw
Loading status checks…
4b324fe 
r? @glennw
@jdm
Copy link
Member

jdm commented Jan 28, 2015 

platform/freetype/font.rs:166:9: 166:29 error: unresolved name `font_stretch::normal`
platform/freetype/font.rs:166         font_stretch::normal
                                      ^~~~~~~~~~~~~~~~~~~~
@jdm jdm removed the S-needs-rebase label Jan 28, 2015
@pcwalton
gfx: Implement `font-stretch` per CSS3-FONTS § 3.3 in the Core Text
Loading status checks…
abddfa7 
font backend.
@pcwalton pcwalton force-pushed the pcwalton:font-stretch branch from 448a9f5 to abddfa7 Jan 28, 2015
@pcwalton

This comment has been minimized.

Sign in to view
Copy link
Owner Author

pcwalton commented on abddfa7 Jan 28, 2015

r=glennw
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on abddfa7 Jan 28, 2015

saw approval from glennw
at pcwalton@abddfa7

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 28, 2015

merging pcwalton/servo/font-stretch = abddfa7 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 28, 2015

pcwalton/servo/font-stretch = abddfa7 merged ok, testing candidate = 3736396

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 28, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/615
success: http://build.servo.org/builders/linux2/builds/614
success: http://build.servo.org/builders/android/builds/650
success: http://build.servo.org/builders/mac1/builds/831
success: http://build.servo.org/builders/mac2/builds/831

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 28, 2015

fast-forwarding master to auto = 3736396
bors-servo pushed a commit that referenced this pull request Jan 28, 2015
bors-servo
auto merge of #4524 : pcwalton/servo/font-stretch, r=glennw
Loading status checks…
3736396 
r? @glennw
@bors-servo bors-servo closed this Jan 28, 2015
@burg burg mentioned this pull request Aug 30, 2015
Closed
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-code-changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @hoppipolla-critic-bot @glennw @jdm @bors-servo
You can’t perform that action at this time.