Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DOMContentLoaded and load asynchronous with using Runnable. #4532

Closed
wants to merge 2 commits into from
Closed

Make DOMContentLoaded and load asynchronous with using Runnable. #4532

wants to merge 2 commits into from

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Jan 2, 2015

Fix #4505
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 2, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3629

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:event branch from f4a0427 to 4d9ec1a Jan 2, 2015
@tetsuharuohzeki tetsuharuohzeki mentioned this pull request Jan 4, 2015
Merged
@jdm jdm added S-needs-squash and removed S-awaiting-review labels Jan 4, 2015
@jdm
Copy link
Member

jdm commented Jan 4, 2015

Squash!
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:event branch from 90af8bb to b33612b Jan 4, 2015
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jan 4, 2015

squashed!
@jdm jdm added S-awaiting-merge and removed S-needs-squash labels Jan 4, 2015
bors-servo pushed a commit that referenced this pull request Jan 4, 2015
bors-servo
auto merge of #4532 : saneyuki/servo/event, r=jdm
Loading status checks…
57c086c 
Fix #4505
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jan 5, 2015

update.
@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Jan 5, 2015
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jan 5, 2015

After adding the follow up commit, I ran mach test-wpt in my local machine. As the result, there are no unexpected results.

@jdm r?
@jdm jdm added S-needs-rebase and removed S-awaiting-review labels Jan 8, 2015
@jdm
Copy link
Member

jdm commented Jan 8, 2015

Looks fine to me; it just needs a rebase now.
@tetsuharuohzeki
Make DOMContentLoaded and load asynchronous with using Runnable.
0237561
@tetsuharuohzeki
Change the reason of disable /html/semantics/document-metadata/the-ba…
Loading status checks…
d8fed6d 
…se-element/base_multiple.html

We haven't support the propagation of load event from iframe.
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:event branch from 4eea750 to d8fed6d Jan 9, 2015
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jan 9, 2015

rebased!
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on d8fed6d Jan 9, 2015

r+

This comment has been minimized.

Sign in to view
Copy link

jdm replied Jan 9, 2015

@bors: retry
@jdm jdm added S-awaiting-merge and removed S-needs-rebase labels Jan 9, 2015
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on d8fed6d Jan 9, 2015

saw approval from jdm
at tetsuharuohzeki@d8fed6d

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

merging saneyuki/servo/event = d8fed6d into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

saneyuki/servo/event = d8fed6d merged ok, testing candidate = 0f12704

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

some tests failed:
failure: http://build.servo.org/builders/mac1/builds/718

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

saw approval from jdm
at tetsuharuohzeki@d8fed6d

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

merging saneyuki/servo/event = d8fed6d into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

saneyuki/servo/event = d8fed6d merged ok, testing candidate = 21fd112

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/502
success: http://build.servo.org/builders/linux2/builds/500
success: http://build.servo.org/builders/android/builds/538
success: http://build.servo.org/builders/mac1/builds/719
success: http://build.servo.org/builders/mac2/builds/719

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

fast-forwarding master to auto = 21fd112
bors-servo pushed a commit that referenced this pull request Jan 9, 2015
bors-servo
auto merge of #4532 : saneyuki/servo/event, r=jdm
Loading status checks…
0f12704 
Fix #4505
bors-servo pushed a commit that referenced this pull request Jan 9, 2015
bors-servo
auto merge of #4532 : saneyuki/servo/event, r=jdm
Loading status checks…
21fd112 
Fix #4505
@bors-servo bors-servo closed this Jan 9, 2015
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:event branch Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Make DOMContentLoaded and load events asynchronous
4 participants
@tetsuharuohzeki @hoppipolla-critic-bot @jdm @bors-servo
You can’t perform that action at this time.