Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Implement `filter` per CSS-FILTERS § 5. #4557

Merged
merged 1 commit into from Jan 9, 2015
Merged

layout: Implement `filter` per CSS-FILTERS § 5. #4557

merged 1 commit into from Jan 9, 2015
+499 −62

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jan 6, 2015

blur and drop-shadow are not yet supported, because the
text-shadow PR makes some fundamental changes to blur rendering that
are needed first.

r? @mbrubeck
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 6, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3659

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 6, 2015

Depends on servo/rust-azure#126.
@pcwalton pcwalton force-pushed the pcwalton:filter branch 2 times, most recently from 8688cda to 6ab83f8 Jan 8, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 8, 2015

Issue addressed. re-r? @mbrubeck
@mbrubeck
Copy link
Contributor

mbrubeck commented Jan 8, 2015

r+, ready for squash
@pcwalton
layout: Implement `filter` per CSS-FILTERS § 5.
Loading status checks…
15d60d7 
`blur` and `drop-shadow` are not yet supported, because the
`text-shadow` PR makes some fundamental changes to blur rendering that
are needed first.
@pcwalton pcwalton force-pushed the pcwalton:filter branch from 6ab83f8 to 15d60d7 Jan 9, 2015
@pcwalton

This comment has been minimized.

Sign in to view
Copy link
Owner Author

pcwalton commented on 15d60d7 Jan 9, 2015

r=mbrubeck
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 15d60d7 Jan 9, 2015

saw approval from mbrubeck
at pcwalton@15d60d7

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

merging pcwalton/servo/filter = 15d60d7 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

pcwalton/servo/filter = 15d60d7 merged ok, testing candidate = ffdbf29

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/496
success: http://build.servo.org/builders/linux2/builds/494
success: http://build.servo.org/builders/android/builds/532
success: http://build.servo.org/builders/mac1/builds/713
success: http://build.servo.org/builders/mac2/builds/713

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 9, 2015

fast-forwarding master to auto = ffdbf29
bors-servo pushed a commit that referenced this pull request Jan 9, 2015
bors-servo
auto merge of #4557 : pcwalton/servo/filter, r=mbrubeck
Loading status checks…
ffdbf29 
`blur` and `drop-shadow` are not yet supported, because the
`text-shadow` PR makes some fundamental changes to blur rendering that
are needed first.

r? @mbrubeck
@bors-servo bors-servo closed this Jan 9, 2015
@bors-servo bors-servo merged commit 15d60d7 into servo:master Jan 9, 2015
1 check passed
1 check passed
default all tests passed
@Ms2ger Ms2ger mentioned this pull request Jan 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-squash
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @hoppipolla-critic-bot @mbrubeck @bors-servo @jdm
You can’t perform that action at this time.