Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement most of the important WindowProxy traps #4594

Merged
merged 1 commit into from Jan 12, 2015
Merged

Implement most of the important WindowProxy traps #4594

merged 1 commit into from Jan 12, 2015

Conversation

@evilpie
Copy link
Contributor

evilpie commented Jan 9, 2015

After this patch somebody just needs to implement the new IndexedGetter (and probably frames/length) on window to fix #4589.
@highfive
Copy link

highfive commented Jan 9, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 9, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3690

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented Jan 9, 2015

Good stuff! I've left some comments on Critic.
@evilpie
Implement most of the important WindowProxy traps
Loading status checks…
d54a45a
@evilpie evilpie force-pushed the evilpie:window-proxy branch from d58ec29 to d54a45a Jan 12, 2015
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on d54a45a Jan 12, 2015

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on d54a45a Jan 12, 2015

saw approval from jdm
at evilpie@d54a45a

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 12, 2015

merging evilpie/servo/window-proxy = d54a45a into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 12, 2015

evilpie/servo/window-proxy = d54a45a merged ok, testing candidate = a227faa

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 12, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/518
success: http://build.servo.org/builders/linux2/builds/516
success: http://build.servo.org/builders/android/builds/554
success: http://build.servo.org/builders/mac1/builds/735
success: http://build.servo.org/builders/mac2/builds/735

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 12, 2015

fast-forwarding master to auto = a227faa
bors-servo pushed a commit that referenced this pull request Jan 12, 2015
bors-servo
auto merge of #4594 : evilpie/servo/window-proxy, r=jdm
Loading status checks…
a227faa 
After this patch somebody just needs to implement the new IndexedGetter (and probably frames/length) on window to fix #4589.
@bors-servo bors-servo closed this Jan 12, 2015
@bors-servo bors-servo merged commit d54a45a into servo:master Jan 12, 2015
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement indexed access on Window (window.frames).
5 participants
@evilpie @highfive @hoppipolla-critic-bot @jdm @bors-servo
You can’t perform that action at this time.