Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStore HTMLIFrameElement sandbox attr as TokenList #4596
Conversation
Fixes #3758 Store the sandbox attribute of HTMLIFrameElement as a TokenList internally. Use .tokens() to iterate over the tokens instead of splitting on the string value. The external interface for sandbox remains a DOMString, which will need to be fixed when DOMSettableTokenList is implemented (#1717).
highfive
commented
Jan 9, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
Jan 9, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/3691 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on e8036ac
Jan 9, 2015
|
r+, looks good! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging jimrhoskins/servo/sandbox-tokenlist = e8036ac into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = ebb702a |
Fixes #3758 Store the sandbox attribute of HTMLIFrameElement as a TokenList internally. Use .tokens() to iterate over the tokens instead of splitting on the string value. The external interface for sandbox remains a DOMString, which will need to be fixed when DOMSettableTokenList is implemented (#1717).
e8036ac
into
servo:master
jimrhoskins commentedJan 9, 2015
Fixes #3758
Store the sandbox attribute of HTMLIFrameElement as a TokenList
internally. Use .tokens() to iterate over the tokens instead of
splitting on the string value.
The external interface for sandbox remains a DOMString, which will need
to be fixed when DOMSettableTokenList is implemented (#1717).