Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store HTMLIFrameElement sandbox attr as TokenList #4596

Merged
merged 1 commit into from Jan 9, 2015

Conversation

@jimrhoskins
Copy link
Contributor

jimrhoskins commented Jan 9, 2015

Fixes #3758

Store the sandbox attribute of HTMLIFrameElement as a TokenList
internally. Use .tokens() to iterate over the tokens instead of
splitting on the string value.

The external interface for sandbox remains a DOMString, which will need
to be fixed when DOMSettableTokenList is implemented (#1717).

Fixes #3758

Store the sandbox attribute of HTMLIFrameElement as a TokenList
internally. Use .tokens() to iterate over the tokens instead of
splitting on the string value.

The external interface for sandbox remains a DOMString, which will need
to be fixed when DOMSettableTokenList is implemented (#1717).
@highfive
Copy link

highfive commented Jan 9, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 9, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3691

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on e8036ac Jan 9, 2015

r+, looks good!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on e8036ac Jan 9, 2015

saw approval from jdm
at jimrhoskins@e8036ac

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 9, 2015

merging jimrhoskins/servo/sandbox-tokenlist = e8036ac into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 9, 2015

jimrhoskins/servo/sandbox-tokenlist = e8036ac merged ok, testing candidate = ebb702a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 9, 2015

fast-forwarding master to auto = ebb702a

bors-servo pushed a commit that referenced this pull request Jan 9, 2015
Fixes #3758

Store the sandbox attribute of HTMLIFrameElement as a TokenList
internally. Use .tokens() to iterate over the tokens instead of
splitting on the string value.

The external interface for sandbox remains a DOMString, which will need
to be fixed when DOMSettableTokenList is implemented (#1717).
@bors-servo bors-servo closed this Jan 9, 2015
@bors-servo bors-servo merged commit e8036ac into servo:master Jan 9, 2015
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.