Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a replacement for Vec<Root<T>> #4620

Closed
wants to merge 3 commits into from
Closed

Implement a replacement for Vec<Root<T>> #4620

wants to merge 3 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Jan 12, 2015

No description provided.

@highfive
Copy link

highfive commented Jan 12, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member Author

jdm commented Jan 12, 2015

By the power vested within me, I summon @Ms2ger to review this.

@jdm jdm closed this Jan 12, 2015
@jdm jdm reopened this Jan 12, 2015
@jdm jdm closed this Jan 12, 2015
@jdm jdm reopened this Jan 12, 2015
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 12, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3711

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

JIoJIaJIu added a commit to JIoJIaJIu/servo that referenced this pull request Mar 1, 2015
@jdm jdm force-pushed the jdm:rooted-vec branch from 788bfc2 to 477363b Mar 1, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 28, 2015

Rebased as #5436

@Ms2ger Ms2ger closed this Mar 28, 2015
@jdm jdm deleted the jdm:rooted-vec branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.