Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix union ABI incompatibility of spidermonkey on ARM arch. #467

Closed
wants to merge 2 commits into from

Conversation

@ILyoan
Copy link
Contributor

ILyoan commented May 22, 2013

This is a fix for #309 and #308 along with servo/rust-mozjs#18.
Change JSVal from u64 to {u64}

@jdm
Copy link
Member

jdm commented May 22, 2013

r+

@metajack

This comment has been minimized.

Copy link

metajack commented on c6b3c2d May 22, 2013

r+

This comment has been minimized.

Copy link

metajack replied May 22, 2013

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on c6b3c2d May 22, 2013

saw approval from metajack
at ILyoan@c6b3c2d

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

merging ILyoan/servo/jsval2 = c6b3c2d into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

ILyoan/servo/jsval2 = c6b3c2d merged ok, testing candidate = ad3d29d

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

saw approval from metajack
at ILyoan@c6b3c2d

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

merging ILyoan/servo/jsval2 = c6b3c2d into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

ILyoan/servo/jsval2 = c6b3c2d merged ok, testing candidate = de2f913

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2013

fast-forwarding master to auto = de2f913

bors-servo pushed a commit that referenced this pull request May 22, 2013
This is a fix for #309 and #308 along with servo/rust-mozjs#18. 
Change JSVal from u64 to {u64}
@metajack
Copy link
Contributor

metajack commented May 22, 2013

The build failed due to leftover stuff from a different pull request integration attempt.

bors-servo pushed a commit that referenced this pull request May 22, 2013
This is a fix for #309 and #308 along with servo/rust-mozjs#18. 
Change JSVal from u64 to {u64}
@bors-servo bors-servo closed this May 22, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Replace ServoStackingContextId with ServoScrollRootId

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/467)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.