Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change of src attributes on iframe (prevents SetLayerOrigin crash). #4676

Closed
wants to merge 1 commit into from
Closed

Fix change of src attributes on iframe (prevents SetLayerOrigin crash). #4676

wants to merge 1 commit into from

Conversation

@glennw
Copy link
Member

glennw commented Jan 20, 2015

No description provided.

@gw3583
Fix change of src attributes on iframe (prevents SetLayerOrigin crash).
Loading status checks…
797658f
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 20, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3789

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@glennw
Copy link
Member Author

glennw commented Jan 20, 2015

r? @mrobinson
@jdm
Copy link
Member

jdm commented Jan 20, 2015

👯
@mrobinson
Copy link
Member

mrobinson commented Jan 20, 2015

Oh man. I noticed this the other day, but hadn't got around to fix it. Thank you!
@mrobinson
Copy link
Member

mrobinson commented Jan 20, 2015

r+
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 797658f Jan 20, 2015

r=mrobinson
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 797658f Jan 20, 2015

saw approval from mrobinson
at glennw@797658f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 20, 2015

merging glennw/servo/iframe-src-fix = 797658f into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 20, 2015

glennw/servo/iframe-src-fix = 797658f merged ok, testing candidate = 0c87faa

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 20, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/579
success: http://build.servo.org/builders/linux2/builds/578
success: http://build.servo.org/builders/android/builds/615
success: http://build.servo.org/builders/mac1/builds/796
success: http://build.servo.org/builders/mac2/builds/796

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 20, 2015

fast-forwarding master to auto = 0c87faa
bors-servo pushed a commit that referenced this pull request Jan 20, 2015
bors-servo
auto merge of #4676 : glennw/servo/iframe-src-fix, r=mrobinson
Loading status checks…
0c87faa
@bors-servo bors-servo closed this Jan 20, 2015
@glennw glennw mentioned this pull request Jan 27, 2015
Closed
@glennw glennw deleted the glennw:iframe-src-fix branch Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @hoppipolla-critic-bot @jdm @mrobinson @bors-servo @gw3583
You can’t perform that action at this time.