Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix various crashes, leaks, and cycles #468
Closed
+155
−27
Conversation
|
r? @metajack |
This comment has been minimized.
This comment has been minimized.
metajack
commented on c8b10ec
May 22, 2013
|
There's one other use of FcPatternCreate in font_list.rs. Should that get the same treatment? |
This comment has been minimized.
This comment has been minimized.
|
That other use is in a place with no early returns, so I didn't bother. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/test/test_hammer_layout.js in 982dd0c
May 22, 2013
|
Was this comment intentional? |
This comment has been minimized.
This comment has been minimized.
|
Yes. |
|
Can you open a bug that the teardown stuff can be removed when we have real GC in Rust? |
|
Opened #470. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 48fbce9
May 22, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/investigate = 48fbce9 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 943139b |
bors-servo
pushed a commit
that referenced
this pull request
May 22, 2013
By the power vested in me through the agency of gdb, massif, and valgrind, here are some changes that fix various crashes that occur when shutting down at arbitrary points, along with some honest-to-goodness shutdown leaks reported by valgrind, and the layout cycles that were causing 1gb/s memory explosions when running test_hammer_layout.html.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Added shader base name to the source Helps debugging when all you got is a shader source (`apitrace`). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/468) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 22, 2013
By the power vested in me through the agency of gdb, massif, and valgrind, here are some changes that fix various crashes that occur when shutting down at arbitrary points, along with some honest-to-goodness shutdown leaks reported by valgrind, and the layout cycles that were causing 1gb/s memory explosions when running test_hammer_layout.html.