Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ToCss for PropertyDeclaration, cleanup CSSStyleDeclaration serialization #4687

Closed
wants to merge 2 commits into from

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jan 20, 2015

Sub-task for #4440.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 20, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3795

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@brunoabinader
Copy link
Contributor Author

brunoabinader commented Jan 20, 2015

@SimonSapin
Copy link
Member

SimonSapin commented Jan 20, 2015

Sorry I was unclear. The idea behind #4455 is to stop using Show for serialization entirely. (And use ToCss instead.) That is, PropertyDeclaration::value and DeclaredValue::specified_value should be replaced with ToCss implementations, and should recursively call .to_css(destination) on their components instead of using format!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.