Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds panic to console.log #4721

Closed
wants to merge 1 commit into from
Closed

Adds panic to console.log #4721

wants to merge 1 commit into from

Conversation

@dmarcos
Copy link
Contributor

dmarcos commented Jan 26, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 26, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3835

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Jan 26, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@jdm
Copy link
Member

jdm commented Jan 27, 2015

Sorry if I wasn't clear - I meant that this is a change you could make locally for testing purposes. We definitely do not want to make the script task panic every time a page uses console.log in a JS script.

@jdm jdm closed this Jan 27, 2015
@dmarcos
Copy link
Contributor Author

dmarcos commented Jan 27, 2015

@jdm This PR is was not meant to be merged yet. It was just to show you the progress I was making. How do you want me to show you work in progress?

@jdm
Copy link
Member

jdm commented Jan 27, 2015

Oh, you can just push to a branch and link to that in github/IRC/email comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.