Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the DOM and layout into separate crates. #474

Merged
merged 9 commits into from May 30, 2013
Merged

Separate the DOM and layout into separate crates. #474

merged 9 commits into from May 30, 2013

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented May 22, 2013

r? @metajack
pcwalton added 5 commits May 20, 2013
@pcwalton
Reduce the number of messages needed to exchange buffers from 3 to 2
729a5ff
@pcwalton
Move the test harnesses into test/.
c658c6d 
This is preparation for removing the `servo-` prefixes from the various
Servo components.
@pcwalton
Remove the `servo-` prefix from core components.
c7bce98
@pcwalton
Introduce a phantom type to prevent script from accessing the layout …
4f3ca37 
…data directly.

Nodes are now parameterized over a "View" type. The particular View type
determines which methods can be called. Layout data accessors and mutators are
only accessible to nodes with a LayoutView. The only way to convert a
`Node<ScriptView>` to a `Node<LayoutView>` is through a transmutation, which is
done at the moment the layout task receives nodes. (This should be factored
better to contain the unsafety.)

We should also lock down DOM node mutation to the ScriptView to forbid data
races, but this patch doesn't do that.

This also reduces coupling between DOM and layout. Soon I would like to move
the DOM into its own crate, and this is a step on the way of doing that.
@pcwalton
Fix merge fallout.
Loading status checks…
83e1bd8
@pcwalton

This comment has been minimized.

Sign in to view
Copy link
Owner Author

pcwalton commented on 83e1bd8 May 28, 2013

r+

This comment has been minimized.

Sign in to view
Copy link

metajack replied May 29, 2013

@bors: retry

This comment has been minimized.

Sign in to view
Copy link

metajack replied May 30, 2013

@bors: retry
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 83e1bd8 May 28, 2013

saw approval from pcwalton
at pcwalton@83e1bd8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 28, 2013

merging pcwalton/servo/phantom-type = 83e1bd8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 28, 2013

pcwalton/servo/phantom-type = 83e1bd8 merged ok, testing candidate = c4fccb4

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 28, 2013

some tests failed:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/37

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 29, 2013

saw approval from pcwalton
at pcwalton@83e1bd8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

saw approval from pcwalton
at pcwalton@83e1bd8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

merging pcwalton/servo/phantom-type = 83e1bd8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

pcwalton/servo/phantom-type = 83e1bd8 merged ok, testing candidate = 90b01df

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

all tests pass:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/44

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

fast-forwarding master to auto = 90b01df
pcwalton added 4 commits May 28, 2013
@pcwalton
Reduce coupling between layout and the DOM by separating out the layo…
0a95672 
…ut interface.

Eventually, the layout interface will be moved along with the DOM into a
separate crate.
@pcwalton
Remove the layout debug methods.
0ea1a94 
Premature abstraction; nothing used the traits polymorphically. Furthermore,
they increased coupling between layout and the DOM.
@pcwalton
Separate the DOM and layout into separate crates.
bf82bc5
@pcwalton
etc: Make tidy more resilient to dirty build directories
Loading status checks…
0b22336
@pcwalton

This comment has been minimized.

Sign in to view
Copy link
Owner Author

pcwalton commented on 0b22336 May 29, 2013

r+

This comment has been minimized.

Sign in to view
Copy link

metajack replied May 30, 2013

@bors: retry
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 0b22336 May 29, 2013

saw approval from pcwalton
at pcwalton@0b22336

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 29, 2013

merging pcwalton/servo/separation = 0b22336 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 29, 2013

pcwalton/servo/separation = 0b22336 merged ok, testing candidate = 07461ed

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 29, 2013

some tests failed:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/38

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

saw approval from pcwalton
at pcwalton@0b22336

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

merging pcwalton/servo/separation = 0b22336 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

pcwalton/servo/separation = 0b22336 merged ok, testing candidate = 473b094

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

all tests pass:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/47

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 30, 2013

fast-forwarding master to auto = 473b094
bors-servo pushed a commit that referenced this pull request May 29, 2013
bors-servo
auto merge of #474 : pcwalton/servo/separation, r=pcwalton
07461ed 
r? @metajack
bors-servo pushed a commit that referenced this pull request May 30, 2013
bors-servo
auto merge of #474 : pcwalton/servo/separation, r=pcwalton
473b094 
r? @metajack
@bors-servo bors-servo merged commit 0b22336 into servo:master May 30, 2013
1 check passed
1 check passed
default all tests passed
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
@bors-servo
Auto merge of servo#474 - kvark:transform, r=glennw
9de780b 
Fixed a number of smoothstep() UB cases in the shaders

Fixed the red rectangle in servo#427, but the text is still broken (to be addressed later).
The change is similar to servo/webrender@b89ecd1, now all `smoothstep` calls should be correct.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/474)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pcwalton @bors-servo @metajack
You can’t perform that action at this time.