Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snapshot dir inside the source dir by default #4755

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mbrubeck
Copy link
Contributor

commented Jan 28, 2015

As discussed in a previous weekly meeting, this avoids changing any directories outside the repo, which is better for some automation scenarios.

The servobuild.example file has a "cache-dir" setting that restores the previous default location of ~/.servo, which is useful for developers working with multiple clones on the same machine.

I'm not sure which setting we want to use for our buildbot hosts.

r? @metajack or @larsbergstrom

Move snapshot dir inside the source dir by default
This avoids changing any directories outside the repo, which is better for
some automation scenarios.

The servobuild.example file has a "cache-dir" setting that restores the
previous default location of `~/.servo`, which is useful for developers
working with multiple clones on the same machine.

@mbrubeck mbrubeck closed this Jan 28, 2015

@mbrubeck mbrubeck reopened this Jan 28, 2015

@hoppipolla-critic-bot

This comment has been minimized.

Copy link

commented Jan 28, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3864

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack

This comment has been minimized.

Copy link

commented on 53135b2 Jan 28, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented on 53135b2 Jan 28, 2015

saw approval from metajack
at mbrubeck@53135b2

This comment has been minimized.

Copy link
Contributor

replied Jan 28, 2015

merging mbrubeck/servo/cache-dir = 53135b2 into auto

This comment has been minimized.

Copy link
Contributor

replied Jan 28, 2015

mbrubeck/servo/cache-dir = 53135b2 merged ok, testing candidate = 74e32d1

This comment has been minimized.

Copy link
Contributor

replied Jan 28, 2015

fast-forwarding master to auto = 74e32d1

bors-servo pushed a commit that referenced this pull request Jan 28, 2015

bors-servo
auto merge of #4755 : mbrubeck/servo/cache-dir, r=metajack
As discussed in a previous weekly meeting, this avoids changing any directories outside the repo, which is better for some automation scenarios.

The servobuild.example file has a "cache-dir" setting that restores the previous default location of `~/.servo`, which is useful for developers working with multiple clones on the same machine.

I'm not sure which setting we want to use for our buildbot hosts.

r? @metajack or @larsbergstrom

@bors-servo bors-servo closed this Jan 28, 2015

bors-servo pushed a commit that referenced this pull request Jan 31, 2015

bors-servo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.