Refactor display lists to use less memory. #476

pcwalton · 2013-05-23T01:42:53Z


        Reduce the number of messages needed to exchange buffers from 3 to 2


        Move the test harnesses into test/.

This is preparation for removing the `servo-` prefixes from the various Servo components.


        Remove the `servo-` prefix from core components.


        Introduce a phantom type to prevent script from accessing the layout …

…data directly. Nodes are now parameterized over a "View" type. The particular View type determines which methods can be called. Layout data accessors and mutators are only accessible to nodes with a LayoutView. The only way to convert a `Node<ScriptView>` to a `Node<LayoutView>` is through a transmutation, which is done at the moment the layout task receives nodes. (This should be factored better to contain the unsafety.) We should also lock down DOM node mutation to the ScriptView to forbid data races, but this patch doesn't do that. This also reduces coupling between DOM and layout. Soon I would like to move the DOM into its own crate, and this is a step on the way of doing that.


        Fix merge fallout.

pcwalton · 2013-05-28T23:22:52Z

r+

metajack · 2013-05-29T17:40:19Z

@bors: retry

metajack · 2013-05-30T02:28:42Z

@bors: retry

bors-servo · 2013-05-28T23:24:26Z

saw approval from pcwalton
at pcwalton@83e1bd8

bors-servo · 2013-05-28T23:24:29Z

merging pcwalton/servo/phantom-type = 83e1bd8 into auto

bors-servo · 2013-05-28T23:24:31Z

pcwalton/servo/phantom-type = 83e1bd8 merged ok, testing candidate = c4fccb4

bors-servo · 2013-05-28T23:42:26Z

some tests failed:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/37

bors-servo · 2013-05-29T17:45:46Z

saw approval from pcwalton
at pcwalton@83e1bd8

bors-servo · 2013-05-30T02:30:44Z

saw approval from pcwalton
at pcwalton@83e1bd8

bors-servo · 2013-05-30T02:30:46Z

merging pcwalton/servo/phantom-type = 83e1bd8 into auto

bors-servo · 2013-05-30T02:30:47Z

pcwalton/servo/phantom-type = 83e1bd8 merged ok, testing candidate = 90b01df

bors-servo · 2013-05-30T02:45:43Z

all tests pass:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/44

bors-servo · 2013-05-30T02:48:44Z

fast-forwarding master to auto = 90b01df


        Reduce coupling between layout and the DOM by separating out the layo…

…ut interface. Eventually, the layout interface will be moved along with the DOM into a separate crate.


        Remove the layout debug methods.

Premature abstraction; nothing used the traits polymorphically. Furthermore, they increased coupling between layout and the DOM.


        Separate the DOM and layout into separate crates.


        etc: Make tidy more resilient to dirty build directories

pcwalton · 2013-05-29T00:49:37Z

r+

metajack · 2013-05-30T07:04:03Z

@bors: retry

bors-servo · 2013-05-29T00:51:26Z

saw approval from pcwalton
at pcwalton@0b22336

bors-servo · 2013-05-29T00:51:28Z

merging pcwalton/servo/separation = 0b22336 into auto

bors-servo · 2013-05-29T00:51:30Z

pcwalton/servo/separation = 0b22336 merged ok, testing candidate = 07461ed

bors-servo · 2013-05-29T01:06:26Z

some tests failed:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/38

bors-servo · 2013-05-30T07:06:39Z

saw approval from pcwalton
at pcwalton@0b22336

bors-servo · 2013-05-30T07:06:41Z

merging pcwalton/servo/separation = 0b22336 into auto

bors-servo · 2013-05-30T07:06:43Z

pcwalton/servo/separation = 0b22336 merged ok, testing candidate = 473b094

bors-servo · 2013-05-30T07:21:39Z

all tests pass:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/47

bors-servo · 2013-05-30T07:24:40Z

fast-forwarding master to auto = 473b094


        Refactor display lists to use less memory.

pcwalton · 2013-05-29T01:55:09Z

r+

metajack · 2013-05-30T07:41:35Z

@bors: retry

bors-servo · 2013-05-29T01:57:26Z

saw approval from pcwalton
at pcwalton@6012a3e

bors-servo · 2013-05-29T01:57:29Z

merging pcwalton/servo/display-list-refactor = 6012a3e into auto

bors-servo · 2013-05-29T01:57:30Z

pcwalton/servo/display-list-refactor = 6012a3e merged ok, testing candidate = 09ce874

bors-servo · 2013-05-29T02:12:27Z

some tests failed:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/39

bors-servo · 2013-05-30T07:42:36Z

saw approval from pcwalton
at pcwalton@6012a3e

bors-servo · 2013-05-30T07:42:38Z

merging pcwalton/servo/display-list-refactor = 6012a3e into auto

bors-servo · 2013-05-30T07:42:39Z

pcwalton/servo/display-list-refactor = 6012a3e merged ok, testing candidate = 273b6cf

bors-servo · 2013-05-30T07:57:35Z

all tests pass:
http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/48

bors-servo · 2013-05-30T08:00:41Z

fast-forwarding master to auto = 273b6cf


        auto merge of #476 : pcwalton/servo/display-list-refactor, r=pcwalton

@metajack

r? @metajack


        auto merge of #476 : pcwalton/servo/display-list-refactor, r=pcwalton

@metajack

r? @metajack


        Merge pull request servo#476 from w3c/deniak/w3c-domhtml

Deniak/w3c domhtml


        Auto merge of servo#476 - jrmuizel:glyph-copy, r=glennw

Remove unneeded copy of glyph buffer  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/476)

pcwalton added 5 commits May 20, 2013

Reduce the number of messages needed to exchange buffers from 3 to 2

729a5ff

Move the test harnesses into test/.

c658c6d

This is preparation for removing the `servo-` prefixes from the various Servo components.

Remove the `servo-` prefix from core components.

c7bce98

Fix merge fallout.

Loading status checks…

83e1bd8

pcwalton added 4 commits May 28, 2013

Reduce coupling between layout and the DOM by separating out the layo…

0a95672

…ut interface. Eventually, the layout interface will be moved along with the DOM into a separate crate.

Remove the layout debug methods.

0ea1a94

Premature abstraction; nothing used the traits polymorphically. Furthermore, they increased coupling between layout and the DOM.

Separate the DOM and layout into separate crates.

bf82bc5

etc: Make tidy more resilient to dirty build directories

Loading status checks…

0b22336

Refactor display lists to use less memory.

Loading status checks…

6012a3e

bors-servo pushed a commit that referenced this pull request May 29, 2013

auto merge of #476 : pcwalton/servo/display-list-refactor, r=pcwalton

09ce874

r? @metajack

bors-servo pushed a commit that referenced this pull request May 30, 2013

auto merge of #476 : pcwalton/servo/display-list-refactor, r=pcwalton

273b6cf

r? @metajack

bors-servo closed this May 30, 2013

bors-servo merged commit 6012a3e into servo:master May 30, 2013
1 check passed

1 check passed

default all tests passed

ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014

Merge pull request servo#476 from w3c/deniak/w3c-domhtml

43b35a0

Deniak/w3c domhtml

servo / servo

Join GitHub today

Refactor display lists to use less memory. #476

Refactor display lists to use less memory. #476

Conversation

pcwalton commented May 23, 2013

This comment has been minimized.

pcwalton commented on 83e1bd8 May 28, 2013

This comment has been minimized.

metajack replied May 29, 2013

This comment has been minimized.

metajack replied May 30, 2013

This comment has been minimized.

bors-servo commented on 83e1bd8 May 28, 2013

This comment has been minimized.

bors-servo replied May 28, 2013

This comment has been minimized.

bors-servo replied May 28, 2013

This comment has been minimized.

bors-servo replied May 28, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

pcwalton commented on 0b22336 May 29, 2013

This comment has been minimized.

metajack replied May 30, 2013

This comment has been minimized.

bors-servo commented on 0b22336 May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

pcwalton commented on 6012a3e May 29, 2013

This comment has been minimized.

metajack replied May 30, 2013

This comment has been minimized.

bors-servo commented on 6012a3e May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 29, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

This comment has been minimized.

bors-servo replied May 30, 2013

pcwalton commented on `83e1bd8` May 28, 2013

bors-servo commented on `83e1bd8` May 28, 2013

pcwalton commented on `0b22336` May 29, 2013

bors-servo commented on `0b22336` May 29, 2013

pcwalton commented on `6012a3e` May 29, 2013

bors-servo commented on `6012a3e` May 29, 2013