Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds borrow_for_script_deallocation and unsafe_mut_js_info method to avo... #4777
Conversation
highfive
commented
Jan 30, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
hoppipolla-critic-bot
commented
Jan 30, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/3874 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Jan 30, 2015
|
|
|
Thanks for sticking with this @dmarcos! I've left two small comments on Critic that should be addressed in an additional commit :) |
|
@jdm. Thanks! I addressed the review comments. Are we done? :) |
|
Squash and I'll merge :) |
|
Done! :) |
|
@jdm Looking now for a second bug to work on. I've seen some work done on the canvas API. Is there any easy stuff on that front that I can tackle? Thanks for your help |
...id 'DOMRefCell already mutably borrowed' messages. This is just a temporary fix until the Rust standard library allows borrowing already-borrowed RefCell values during unwinding. It also removes LiveDOMReferences destructor that it's a no-op but it contains an assert that was being violated causing an endless cycle of destructor calls ending up in a stack overflow.
…avoid 'DOMRefCell already mutably borrowed' messages. This is just a temporary fix until the Rust standard library allows borrowing already-borrowed RefCell values during unwinding. It also removes LiveDOMReferences destructor that it's a no-op but it contains an assert that was being violated causing an endless cycle of destructor calls ending up in a stack overflow.
This comment has been minimized.
This comment has been minimized.
jdm
commented on 7b9c902
Jan 30, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging dmarcos/servo/issue4692 = 7b9c902 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = a7e2993 |
...id 'DOMRefCell already mutably borrowed' messages. This is just a temporary fix until the Rust standard library allows borrowing already-borrowed RefCell values during unwinding. It also removes LiveDOMReferences destructor that it's a no-op but it contains an assert that was being violated causing an endless cycle of destructor calls ending up in a stack overflow.
dmarcos commentedJan 30, 2015
...id 'DOMRefCell already mutably borrowed' messages. This is just a temporary fix until the Rust standard library allows borrowing already-borrowed RefCell values during unwinding.
It also removes LiveDOMReferences destructor that it's a no-op but it contains an assert that was being violated causing an endless cycle of destructor calls ending up in a stack overflow.