Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the glfw port (it doesn't compile since last rustup anyway). #4798

Closed
wants to merge 1 commit into from

Conversation

@glennw
Copy link
Member

glennw commented Feb 2, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 2, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3888

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Feb 2, 2015

Not sure if we should wait until next meeting to check if there's any objections / glutin issues before we merge this?

r? @larsbergstrom

@SimonSapin
Copy link
Member

SimonSapin commented Feb 2, 2015

It’s in the git history, we can always bring it back if necessary.

@SimonSapin
Copy link
Member

SimonSapin commented Feb 2, 2015

+10 −744

:)

@SimonSapin

This comment has been minimized.

Copy link

SimonSapin commented on f495884 Feb 2, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on f495884 Feb 2, 2015

saw approval from SimonSapin
at glennw@f495884

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 2, 2015

merging glennw/servo/remove-glfw = f495884 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 2, 2015

glennw/servo/remove-glfw = f495884 merged ok, testing candidate = 896cdcb

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 2, 2015

fast-forwarding master to auto = 896cdcb

bors-servo pushed a commit that referenced this pull request Feb 2, 2015
@bors-servo bors-servo closed this Feb 2, 2015
@brendanzab
Copy link
Member

brendanzab commented Feb 2, 2015

Huzzah!

@glennw glennw deleted the glennw:remove-glfw branch Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.