Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnderline layout and rendering #480
Closed
Conversation
added 4 commits
May 21, 2013
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/servo-gfx/text/text_run.rs in 1016e27
May 24, 2013
|
|
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/servo-gfx/text/text_run.rs in 1016e27
May 24, 2013
|
Same here. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/servo/layout/inline.rs in 1016e27
May 24, 2013
|
The style is words separated by underscores. So this should be |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Move MS tests on forms
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Isolate GL calls to the device only Also used by the WebGL module, but cutting that tie off would be a much bigger task. This PR makes the code a bit cleaner, also paves the way to servo#407. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/480) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fix GL stencil state This was a typo from servo#480 Found out by qApitrace log: > major api error 14: GL_INVALID_ENUM in glDisable(GL_STENCIL) Perhaps, we should check for gl errors in the code too. We seem to only do that for WebGL commands at this point. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/500) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric93 commentedMay 24, 2013
Add support for underlines to layout and servo-gfx.