Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement window.parent for iframes. #4811

Merged
merged 1 commit into from Feb 4, 2015
Merged

Implement window.parent for iframes. #4811

merged 1 commit into from Feb 4, 2015

Conversation

@glennw
Copy link
Member

glennw commented Feb 3, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 3, 2015

Critic review: https://critic.hoppipolla.co.uk/r/3899

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@glennw
Copy link
Member Author

glennw commented Feb 3, 2015

@jdm or @Ms2ger I'm just trying to find my way around the DOM code. Is this patch a reasonable approach or is there a much better way to implement window.parent?
@jdm jdm mentioned this pull request Feb 3, 2015
Closed
@jdm
Copy link
Member

jdm commented Feb 3, 2015

This design seems reasonable, although it's tempting to look for ways to store a parent browser context, rather than a parent window.
@jdm
Copy link
Member

jdm commented Feb 4, 2015

Squash!
@glennw glennw force-pushed the glennw:window_parent branch from 7891833 to 363f583 Feb 4, 2015
@gw3583
Implement window.parent for iframes.
Loading status checks…
0873e5c
@glennw glennw force-pushed the glennw:window_parent branch from 363f583 to 0873e5c Feb 4, 2015
@glennw
Copy link
Member Author

glennw commented Feb 4, 2015

Squashed and rebased!
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 0873e5c Feb 4, 2015

r+
@jdm jdm added S-awaiting-merge and removed S-needs-squash labels Feb 4, 2015
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 0873e5c Feb 4, 2015

saw approval from jdm
at glennw@0873e5c

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 4, 2015

merging glennw/servo/window_parent = 0873e5c into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 4, 2015

glennw/servo/window_parent = 0873e5c merged ok, testing candidate = 0beb070

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 4, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/694
success: http://build.servo.org/builders/linux2/builds/693
success: http://build.servo.org/builders/android/builds/729
success: http://build.servo.org/builders/mac1/builds/910
success: http://build.servo.org/builders/mac2/builds/910

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 4, 2015

fast-forwarding master to auto = 0beb070
bors-servo pushed a commit that referenced this pull request Feb 4, 2015
bors-servo
auto merge of #4811 : glennw/servo/window_parent, r=jdm
Loading status checks…
0beb070
@bors-servo bors-servo closed this Feb 4, 2015
@bors-servo bors-servo merged commit 0873e5c into servo:master Feb 4, 2015
1 check passed
1 check passed
default all tests passed
@glennw glennw deleted the glennw:window_parent branch Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@glennw @hoppipolla-critic-bot @jdm @bors-servo @gw3583
You can’t perform that action at this time.