Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor TextRenderBox #485
Merged
+56
−80
Conversation
…ox's style handle font size
This comment has been minimized.
This comment has been minimized.
burg
commented on 5c8c776
May 27, 2013
|
LGTM. r+ |
This comment has been minimized.
This comment has been minimized.
jdm
replied
May 27, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging oncemoreification/servo/refactor_TextRenderBox = 5c8c776 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 8f33dfa |
bors-servo
pushed a commit
that referenced
this pull request
May 27, 2013
…r=jdm This removes the TextBoxData struct and places its properties directly on the TextRenderBox. It also removes the font_size property from RenderBox's, in the thinking that this should be (and is) managed by stylers.
bors-servo
merged commit 5c8c776
into
servo:master
1 check passed
1 check passed
default
all tests passed
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add framework for dynamic/cache render tasks, and use for box shadows. This adds the framework for tiles and primitives to add dependent render tasks. The proof of concept in this patch uses them to speed up box shadow rendering, but the dynamic render tasks can be used for many things in the future. For example, we can use this system to render rotated clip masks, or cache text runs to a texture. The box shadows are rendered by adding a child task that draws the upper left corner of a box shadow. The primitive shader for box shadows then applies this rendered patch over the box shadow by clamping and mirroring the texture coordinates in the fragment shader. Dynamic render tasks are added to passes via a cache key that is defined based on the type of item being cached. This means that dynamic render tasks are du-duplicated during allocation and assignment to render passes and targets. This means that if different tiles require the same cache primitive, it will only get rendered once. It also means that if two primitive exist that require the same resource type (e.g. two box shadows with different colors but same size and blur radius) then the cache item will only be drawn once to the child render target. With this change, GPU time on transparent_rects demo drops from 16ms down to 9ms on my test setup. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/485) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jjjjw commentedMay 26, 2013
This removes the TextBoxData struct and places its properties directly on the TextRenderBox.
It also removes the font_size property from RenderBox's, in the thinking that this should be (and is) managed by stylers.