Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAlign text at baseline #488
Merged
Conversation
added 2 commits
May 27, 2013
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add a few comments to the code. This isn't much but it's a start and was a good exercise to get started with the code. This PR adds a few comments next to some areas that looked important while not being immediately obvious to me. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/488) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric93 commentedMay 28, 2013
Aligns text based on baseline, as opposed to some weird alignment happening now. Makes underline look better, but a full solution would implement line-height and text-align.