Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion single Color patch. #4903

Merged
merged 1 commit into from Feb 13, 2015
Merged

Companion single Color patch. #4903

merged 1 commit into from Feb 13, 2015

Conversation

@Adenilson
Copy link
Contributor

Adenilson commented Feb 12, 2015

No description provided.

@Adenilson Adenilson force-pushed the Adenilson:singleColor02 branch from bda6e38 to 5114671 Feb 13, 2015
@Adenilson Adenilson changed the title Companion single Color patch. Not for commit. Companion single Color patch. Feb 13, 2015
@Adenilson
Copy link
Contributor Author

Adenilson commented Feb 13, 2015

Rebased with current master, executed ref-tests (OSX Yosemite), everything looks fine.
components/gfx/color.rs Outdated
#[inline]
pub fn new(r: AzFloat, g: AzFloat, b: AzFloat, a: AzFloat) -> AzColor {
AzColor { r: r, g: g, b: b, a: a }
}

This comment has been minimized.

Sign in to view
@pcwalton

pcwalton Feb 13, 2015

Contributor

nit: weird indentation here

This comment has been minimized.

Sign in to view
@pcwalton

pcwalton Feb 13, 2015

Contributor

Also, why does this need to exist at all? Shouldn't this be moved into rust-azure if anything?

This comment has been minimized.

Sign in to view
@pcwalton

pcwalton Feb 13, 2015

Contributor

After discussion on IRC this is fine to leave here. But please fix the indentation :)
@Adenilson
Copy link
Contributor Author

Adenilson commented Feb 13, 2015

Updated.
@pcwalton
Copy link
Contributor

pcwalton commented Feb 13, 2015

Squash and ready to merge!
@Adenilson
Companion single Color patch.
Loading status checks…
ffa62c9 
This will also update the rust-azure dependency
to point to the hash where we have a single Color type.

Just executed ref-tests and no regressions found.
@Adenilson Adenilson force-pushed the Adenilson:singleColor02 branch from 3dbef05 to ffa62c9 Feb 13, 2015
@pcwalton

This comment has been minimized.

Sign in to view
Copy link

pcwalton commented on ffa62c9 Feb 13, 2015

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on ffa62c9 Feb 13, 2015

saw approval from pcwalton
at Adenilson@ffa62c9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 13, 2015

merging Adenilson/servo/singleColor02 = ffa62c9 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 13, 2015

Adenilson/servo/singleColor02 = ffa62c9 merged ok, testing candidate = b5749e9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 13, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/756
success: http://build.servo.org/builders/linux2/builds/755
success: http://build.servo.org/builders/android/builds/791
success: http://build.servo.org/builders/mac1/builds/972
success: http://build.servo.org/builders/mac2/builds/972

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 13, 2015

fast-forwarding master to auto = b5749e9
bors-servo pushed a commit that referenced this pull request Feb 13, 2015
bors-servo
auto merge of #4903 : Adenilson/servo/singleColor02, r=pcwalton
Loading status checks…
b5749e9
@bors-servo bors-servo closed this Feb 13, 2015
@bors-servo bors-servo merged commit ffa62c9 into servo:master Feb 13, 2015
1 check passed
1 check passed
default all tests passed
@Adenilson Adenilson mentioned this pull request Feb 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Adenilson @pcwalton @bors-servo @jdm
You can’t perform that action at this time.