Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInitial support for line heights calculations. #493
Merged
+129
−92
Conversation
and others
added 3 commits
May 29, 2013
|
I based these changes against auto. Because it seemed like there was a bunch of stuff there that I didn't want to cause merge conflicts with when they made it to master. Let me know if that was the wrong thing to do. |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging jrfeenst/servo/line-height = 0ff196d into auto |
This comment has been minimized.
This comment has been minimized.
bors-servo
pushed a commit
that referenced
this pull request
May 30, 2013
This calculates the line-height of each line box based on the tallest box in the line. It then lines up the baselines of all the other boxes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrfeenst commentedMay 30, 2013
This calculates the line-height of each line box based on the tallest box in the line. It then lines up the baselines of all the other boxes.