Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bloom filter churn. #4938

Merged
merged 2 commits into from Feb 16, 2015
Merged

Commits on Feb 16, 2015

  1. Avoid bloom filter churn.

    When a cached bloom filter is found during traversal, there are two
    cases, both of which currently do unnecessary allocations. This patch
    avoids these allocations. In the process, it renders correct two
    previously-incorrect comments, and moves one of those comments into a
    better spot.
    
    While scrolling moderately fast all the way through the "Guardians of
    the Galaxy" Wikipedia page, this patch (a) avoids 1.2 million calls to
    `clone()` and (b) replaces 111,000 `BloomFilter::new()` calls with
    `clear()` calls.
    nnethercote committed Feb 16, 2015
  2. Update a comment about STYLE_BLOOM.

    nnethercote committed Feb 16, 2015
You can’t perform that action at this time.