Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change window title to reflect document title #4951

Merged
merged 2 commits into from Feb 18, 2015
Merged

Conversation

@glennw
Copy link
Member

glennw commented Feb 18, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 18, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4011

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Feb 18, 2015

r? @jdm or @mbrubeck

@mbrubeck

This comment has been minimized.

Copy link

mbrubeck commented on 56eedba Feb 18, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 56eedba Feb 18, 2015

saw approval from mbrubeck
at glennw@56eedba

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

merging glennw/servo/set-title = 56eedba into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

glennw/servo/set-title = 56eedba merged ok, testing candidate = 357028d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

bors-servo pushed a commit that referenced this pull request Feb 18, 2015
@jdm jdm removed the S-awaiting-review label Feb 18, 2015
@jdm
Copy link
Member

jdm commented Feb 18, 2015

Failed due to an assertion being fixed in servo/cocoa-rs#72.

@glennw
Copy link
Member Author

glennw commented Feb 18, 2015

Updated rust-cocoa to fix mac/wpt crash caused by init_str method bug. re-r? @mbrubeck or @jdm

@jdm

This comment has been minimized.

Copy link

jdm commented on b789424 Feb 18, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on b789424 Feb 18, 2015

saw approval from jdm
at glennw@b789424

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

merging glennw/servo/set-title = b789424 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

glennw/servo/set-title = b789424 merged ok, testing candidate = dc31d96

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 18, 2015

fast-forwarding master to auto = dc31d96

bors-servo pushed a commit that referenced this pull request Feb 18, 2015
@bors-servo bors-servo closed this Feb 18, 2015
@bors-servo bors-servo merged commit b789424 into servo:master Feb 18, 2015
1 check passed
1 check passed
default all tests passed
@glennw glennw deleted the glennw:set-title branch Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.