Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange window title to reflect document title #4951
Conversation
hoppipolla-critic-bot
commented
Feb 18, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4011 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
mbrubeck
commented on 56eedba
Feb 18, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from mbrubeck |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/set-title = 56eedba into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
|
Failed due to an assertion being fixed in servo/cocoa-rs#72. |
This comment has been minimized.
This comment has been minimized.
jdm
commented on b789424
Feb 18, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/set-title = b789424 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = dc31d96 |
b789424
into
servo:master
glennw commentedFeb 18, 2015
No description provided.