Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove js to libc from crates.io. #4963
Conversation
hoppipolla-critic-bot
commented
Feb 19, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4021 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 63f6063
Feb 19, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Feb 19, 2015
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging Ms2ger/servo/js-libc = 63f6063 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging Ms2ger/servo/js-libc = 63f6063 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = d94bd27 |
Requires servo/rust-mozjs#136.
Requires servo/rust-mozjs#136.
63f6063
into
servo:master
Ms2ger commentedFeb 19, 2015
Requires servo/rust-mozjs#136.