Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate rust-css and rust-netsurfcss #497
Closed
Conversation
|
This will get done with the rollup in #512 |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Update and cleanup Microsoft's video tests.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Text transformation fixes Fixes servo#427 well, mostly... Looks like the transformed clips (servo#498) need to be implemented for this to work fully correct. Also adds a bit of comments to GLSL code to understand what's going on (please check if I misunderstood stuff and documented it wrong!). The errors spotted: 1. `layer.screen_vertices` was fetched with wrong indices 2. `untransform` would use undefined value of `t` if the layer plane is perpendicular to the view 3. text vertex shaders were missing a division by `vi.local_pos.z` for the layer coordinates 4. `prim.local_rect` was used for the text_run local rectangle, instead of `local_rect` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/497) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sethfowler commentedMay 31, 2013
Update rust-css and rust-netsurfcss to pull in recent changes including support for padding.