Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMore conversions of with_imm_base to with_base #498
Closed
Conversation
|
Merged into my branch. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
On http://::@c@d:2 pass should be :%40c not :c%40
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Text transformation fixes Fixes servo#427 well, mostly... Looks like the transformed clips (servo#498) need to be implemented for this to work fully correct. Also adds a bit of comments to GLSL code to understand what's going on (please check if I misunderstood stuff and documented it wrong!). The errors spotted: 1. `layer.screen_vertices` was fetched with wrong indices 2. `untransform` would use undefined value of `t` if the layer plane is perpendicular to the view 3. text vertex shaders were missing a division by `vi.local_pos.z` for the layer coordinates 4. `prim.local_rect` was used for the text_run local rectangle, instead of `local_rect` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/497) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Introduced sub_index field to the PimitiveInstance This PR achieves 2 things: 1. Attempts to define one of our `user_data` fields more clearly (`sub_index`) 2. Frees up one of the `user_data` fields to be used for the clip task index (servo#498) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/516) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Major refactoring of how clips are processed down the pipeline This moves the clipping hack down the road (from `Frame` to `FrameBuilder`), allowing to eventually implement multiple transformed clips properly (servo#498), as discussed on IRC with @glennw . <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/512) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Off-screen clip mask generation This is the second major step towards servo#498 Edit: now actually includes the third step as well (removal of `*_clip` shaders). The PR makes all the clip masks to be generated via the cached rendering tasks (of the new kind). These task work on the area of intersection between all the clip items. The resulting draw calls are being batched via the new `ClipBatcher`. It supports everything that we currently support, plus the actual handling of arbitrary number of clips. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/556) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sethfowler commentedMay 31, 2013
This eliminates more instances of with_imm_base and makes the code more consistent.