Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `rust-media` as a dependency of script, in preparation for audio and video tag support #4990

Closed
wants to merge 2 commits into from
Closed

Add `rust-media` as a dependency of script, in preparation for audio and video tag support #4990

wants to merge 2 commits into from

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Feb 20, 2015

This does not actually use the library; it's just here to prevent
bitrotting.

r? @metajack @glennw
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 20, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4037

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton pcwalton force-pushed the pcwalton:rust-media branch from e4cb497 to 8bd4786 Feb 20, 2015
@jdm
Copy link
Member

jdm commented Feb 24, 2015

This is missing changes from the other Cargo.lock files, but otherwise looks totally fine to me.
pcwalton added 2 commits Feb 20, 2015
@pcwalton
Add `rust-media` as a dependency of script, in preparation for audio and
ddcd335 
video tag support.

This does not actually use the library; it's just here to prevent
bitrotting.
@pcwalton
Fix missing Cargo.locks
Loading status checks…
6ca104a
@pcwalton pcwalton force-pushed the pcwalton:rust-media branch from 8bd4786 to 6ca104a Feb 25, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Feb 25, 2015

Issue addressed. r? @metajack
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 6ca104a Feb 25, 2015

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 6ca104a Feb 25, 2015

saw approval from metajack
at pcwalton@6ca104a

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

merging pcwalton/servo/rust-media = 6ca104a into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

pcwalton/servo/rust-media = 6ca104a merged ok, testing candidate = 6a6bc40

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

some tests failed:
failure: http://build.servo.org/builders/linux1/builds/855
failure: http://build.servo.org/builders/linux2/builds/853
failure: http://build.servo.org/builders/mac1/builds/1070
failure: http://build.servo.org/builders/mac2/builds/1070
bors-servo pushed a commit that referenced this pull request Feb 25, 2015
bors-servo
auto merge of #4990 : pcwalton/servo/rust-media, r=metajack
Loading status checks…
6a6bc40 
This does not actually use the library; it's just here to prevent
bitrotting.

r? @metajack @glennw
@jdm
Copy link
Member

jdm commented Feb 25, 2015 

Unable to update https://github.com/pcwalton/rust-media#8a428094
@jdm jdm removed the S-needs-rebase label Feb 25, 2015
@pcwalton pcwalton force-pushed the servo:master branch from fed8787 to bf60477 Mar 2, 2015
@jdm
Copy link
Member

jdm commented Mar 28, 2015

No real point in keeping this open; it's super simple to redo from scratch.
@jdm jdm closed this Mar 28, 2015
@boghison boghison mentioned this pull request Jul 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-code-changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @hoppipolla-critic-bot @jdm @bors-servo @metajack
You can’t perform that action at this time.