Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MIME sniffing #5005

Merged
merged 6 commits into from Apr 7, 2015
Merged

Implement MIME sniffing #5005

merged 6 commits into from Apr 7, 2015

Conversation

@jdm
Copy link
Member

jdm commented Feb 21, 2015

This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a --sniff-mime-types command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
@jdm jdm mentioned this pull request Feb 21, 2015
Closed
@jdm
Copy link
Member Author

jdm commented Feb 21, 2015

Fixes #3144.
@jdm jdm closed this Feb 21, 2015
@jdm jdm reopened this Feb 21, 2015
@jdm jdm closed this Feb 22, 2015
@jdm jdm reopened this Feb 22, 2015
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 22, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4054

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member Author

jdm commented Feb 24, 2015

@metajack Would you like to review this? I reviewed the actual sniffing implementation in the first commit, so it's just the network integration in the subsequent commits that needs reviewing.
@jdm jdm added the S-needs-rebase label Feb 24, 2015
@jdm jdm mentioned this pull request Mar 11, 2015
Closed
@metajack metajack self-assigned this Mar 31, 2015
@metajack
Copy link
Contributor

metajack commented Mar 31, 2015

@jdm Yes, I'll review.
@metajack
Copy link
Contributor

metajack commented Apr 1, 2015

Reviewed in Critic.
IdeaHat and others added 3 commits Nov 14, 2014
@IdeaHat @jdm
Implement MIME sniffing.
44930b0
@jdm
Remove the sniffer task.
2d730f2
@jdm
Enable optional mime sniffing, and integrate it with the file loader.
a3201bc
@jdm jdm force-pushed the jdm:mime-sniffing branch from 794bcb4 to 7355ebb Apr 7, 2015
@jdm
Copy link
Member Author

jdm commented Apr 7, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit ec79ab0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit ec79ab0 with merge ec45020...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5005 - jdm:mime-sniffing, r=jdm
ec45020 
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
@jdm jdm added the S-awaiting-merge label Apr 7, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

💔 Test failed - mac1
@jdm jdm force-pushed the jdm:mime-sniffing branch from ec79ab0 to a1a3035 Apr 7, 2015
@jdm
Copy link
Member Author

jdm commented Apr 7, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit a1a3035 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit a1a3035 with merge 85c75ba...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5005 - jdm:mime-sniffing, r=jdm
85c75ba 
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
@jdm
Copy link
Member Author

jdm commented Apr 7, 2015 


/XMLHttpRequest/getresponseheader-chunked-trailer.htm
-----------------------------------------------------
TIMEOUT expected FAIL XMLHttpRequest: getResponseHeader() and HTTP trailer
TIMEOUT [Parent]
/XMLHttpRequest/response-data-gzip.htm
--------------------------------------
CRASH [Parent]
/XMLHttpRequest/send-conditional.htm
------------------------------------
PASS expected FAIL XMLHttpRequest: send() - conditional requests (tag)
PASS expected FAIL XMLHttpRequest: send() - conditional requests (date)
/XMLHttpRequest/progress-events-response-data-gzip.htm
------------------------------------------------------
TIMEOUT expected FAIL XMLHttpRequest: progress events and GZIP encoding
TIMEOUT [Parent]
@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Apr 7, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

💔 Test failed - linux2
@jdm
Copy link
Member Author

jdm commented Apr 7, 2015

@bors-servo: r-
jdm added 3 commits Feb 21, 2015
@jdm
Enable MIME sniffing for HTTP loads.
23ae940
@jdm
Fix unit tests.
4a78da1
@jdm
Cleanup tabs.
Loading status checks…
9674fee
@jdm jdm force-pushed the jdm:mime-sniffing branch from a1a3035 to 9674fee Apr 7, 2015
@jdm
Copy link
Member Author

jdm commented Apr 7, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit 9674fee has been approved by jdm
@jdm jdm added S-awaiting-merge and removed S-tests-failed labels Apr 7, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit 9674fee with merge c7e210f...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5005 - jdm:mime-sniffing, r=jdm
Loading status checks…
c7e210f 
This rebases and integrates #4209, removing the sniffer task (turns out it wasn't a great idea), and adds a `--sniff-mime-types` command line flag to enable sniffing for file:// and http:// resources. Tested against a random picture file on my harddrive. The actual MIME sniffing implementation can be extracted into a separate library separately.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 9674fee into servo:master Apr 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 7, 2015
Merged
@jdm jdm mentioned this pull request Apr 8, 2015
Merged
@jdm jdm deleted the jdm:mime-sniffing branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @hoppipolla-critic-bot @metajack @bors-servo @IdeaHat
You can’t perform that action at this time.