Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInitial support for line heights calculations. #502
Closed
Conversation
and others
added 3 commits
May 29, 2013
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging jrfeenst/servo/line-height = 0ff196d into auto |
This comment has been minimized.
This comment has been minimized.
…es are expecting pixels, not points like the docs say. The glyph advance is also scaled slightly to match what is show in Firefox.
|
@jrfeenst This seems to need a rebase. |
|
I'm still working on the font size issues. It seems fine on mac now, but the font metrics are all wrong on Linux. I'll reopen this once I've fixed everything and rebased. |
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Local rectangle clipping for transformed primitives Finishes servo#427 implementation, now the text is cut evenly and not aligned to tile borders. Also refactored `build_bounding_rect()` as well as a bit of `assign_prims_to_screen_tiles()`.  <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/502) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrfeenst commentedJun 1, 2013
No description provided.