Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Canvas pixel manipulation #5020

Merged
merged 1 commit into from Feb 22, 2015
Merged

Implement Canvas pixel manipulation #5020

merged 1 commit into from Feb 22, 2015

Conversation

@jdm
Copy link
Member

jdm commented Feb 22, 2015

Rebase of #4639.

@highfive
Copy link

highfive commented Feb 22, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 22, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4060

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Feb 22, 2015
bors-servo
Rebase of #4639.
@jdm jdm force-pushed the jdm:canvas branch from df7411b to 605f905 Feb 22, 2015
bors-servo pushed a commit that referenced this pull request Feb 22, 2015
bors-servo
Rebase of #4639.
@jdm jdm force-pushed the jdm:canvas branch from 605f905 to 325400d Feb 22, 2015
@jdm

This comment has been minimized.

Copy link
Owner

jdm commented on 325400d Feb 22, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 325400d Feb 22, 2015

saw approval from jdm
at jdm@325400d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 22, 2015

merging jdm/servo/canvas = 325400d into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 22, 2015

jdm/servo/canvas = 325400d merged ok, testing candidate = 287f390

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 22, 2015

fast-forwarding master to auto = 287f390

bors-servo pushed a commit that referenced this pull request Feb 22, 2015
bors-servo
Rebase of #4639.
@bors-servo bors-servo closed this Feb 22, 2015
@bors-servo bors-servo merged commit 325400d into servo:master Feb 22, 2015
1 check passed
1 check passed
default all tests passed
@jdm jdm deleted the jdm:canvas branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.