Move body of ScriptTask::handle_mouse_move_event into a method on

[JIoJIaJIu]

Document #4984

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/4075

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[kmcallister]

Nit: don't need a blank line here

[kmcallister]

Nit: space before (

[kmcallister]

Also can you wrap this line, and the line added in the trait, to fit within 100 columns (ideally, 80)?

[kmcallister]

r=me with those syntax tweaks

[JIoJIaJIu]

Can you give me advise how to wrap func, please?

[jdm]

Just move arguments that go beyond 80 characters on to the next line, starting in the same column as the arguments on the previous line.

[JIoJIaJIu]

Omg, excuse me)

[JIoJIaJIu]

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend)

But when im trying to make pull ustream master i've got merge conflict.
What is the best way to avoid this? Thx

[jdm]

Ah, the best solution there is to use branches when making commits. I leave master tracking the upstream master, and rebase my feature branches based on it.

[jdm]

You could do

git reset --hard 1eef07c
git checkout -b move_fn
git checkout master
git reset --hard f0b5794e44a2a28212aaf3fac4c340a3f32a8515

and then you should have a master branch that can be pulled from upstream again. You'll need to make a new pull request for the new move_fn branch, though.

[JIoJIaJIu]

thank you @jdm
#5073