Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix parsing of text decorations. #5061

Merged
merged 1 commit into from Feb 25, 2015
Merged

style: Fix parsing of text decorations. #5061

merged 1 commit into from Feb 25, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Feb 25, 2015

Adds a reftest so it doesn't break again.

r? @mbrubeck
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 25, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4098

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton
style: Fix parsing of text decorations.
Loading status checks…
f188278 
Adds a reftest so it doesn't break again.
@pcwalton pcwalton force-pushed the pcwalton:fix-text-decoration branch from 8f02e66 to f188278 Feb 25, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Feb 25, 2015

re-r? @mbrubeck
@pcwalton pcwalton mentioned this pull request Feb 25, 2015
Closed
@mbrubeck

This comment has been minimized.

Sign in to view
Copy link

mbrubeck commented on f188278 Feb 25, 2015

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on f188278 Feb 25, 2015

saw approval from mbrubeck
at pcwalton@f188278

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

merging pcwalton/servo/fix-text-decoration = f188278 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

pcwalton/servo/fix-text-decoration = f188278 merged ok, testing candidate = cbc4b95

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/856
success: http://build.servo.org/builders/linux2/builds/854
success: http://build.servo.org/builders/android/builds/890
success: http://build.servo.org/builders/mac1/builds/1071
success: http://build.servo.org/builders/mac2/builds/1071
success: http://build.servo.org/builders/gonk/builds/42

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Feb 25, 2015

fast-forwarding master to auto = cbc4b95
bors-servo pushed a commit that referenced this pull request Feb 25, 2015
bors-servo
auto merge of #5061 : pcwalton/servo/fix-text-decoration, r=mbrubeck
Loading status checks…
cbc4b95 
Adds a reftest so it doesn't break again.

r? @mbrubeck
@bors-servo bors-servo closed this Feb 25, 2015
@bors-servo bors-servo merged commit f188278 into servo:master Feb 25, 2015
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@pcwalton @hoppipolla-critic-bot @bors-servo @mbrubeck
You can’t perform that action at this time.