Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove body of ScriptTask::handle_mouse_move_event into a method on Document (fixes #5032). #5073
Conversation
highfive
commented
Feb 26, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
hoppipolla-critic-bot
commented
Feb 26, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4113 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Looks good! Just needs a squash and rebase before we merge it :) |
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on 94e7f89
Feb 28, 2015
|
r=jdm |
|
fixes #5032 |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging JIoJIaJIu/servo/handle_mouse_event = 94e7f89 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 75060f4 |
JIoJIaJIu commentedFeb 26, 2015
No description provided.