Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move body of ScriptTask::handle_mouse_move_event into a method on Document (fixes #5032). #5073

Closed
wants to merge 1 commit into from

Conversation

@JIoJIaJIu
Copy link
Contributor

JIoJIaJIu commented Feb 26, 2015

No description provided.

@highfive
Copy link

highfive commented Feb 26, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 26, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4113

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

JIoJIaJIu added a commit to JIoJIaJIu/servo that referenced this pull request Feb 26, 2015
JIoJIaJIu added a commit to JIoJIaJIu/servo that referenced this pull request Feb 26, 2015
@jdm
Copy link
Member

jdm commented Feb 28, 2015

Looks good! Just needs a squash and rebase before we merge it :)

@JIoJIaJIu JIoJIaJIu force-pushed the JIoJIaJIu:handle_mouse_event branch from e464bc3 to 94e7f89 Feb 28, 2015
@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on 94e7f89 Feb 28, 2015

r=jdm

@Ms2ger Ms2ger changed the title Move body of ScriptTask::handle_mouse_move_event into a method on #5032 Move body of ScriptTask::handle_mouse_move_event into a method on Document (fixes #5032). Feb 28, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 28, 2015

fixes #5032

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 94e7f89 Feb 28, 2015

saw approval from jdm
at JIoJIaJIu@94e7f89

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 28, 2015

merging JIoJIaJIu/servo/handle_mouse_event = 94e7f89 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 28, 2015

JIoJIaJIu/servo/handle_mouse_event = 94e7f89 merged ok, testing candidate = 75060f4

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 28, 2015

fast-forwarding master to auto = 75060f4

bors-servo pushed a commit that referenced this pull request Feb 28, 2015
@bors-servo bors-servo closed this Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.