Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test-wpt supports --release argument #5074

Merged
merged 1 commit into from Feb 26, 2015
Merged

Conversation

@acgtyrant
Copy link
Contributor

acgtyrant commented Feb 26, 2015

Fixes #5056

@highfive
Copy link

highfive commented Feb 26, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 26, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4114

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Manishearth
Copy link
Member

Manishearth commented Feb 26, 2015

This doesn't work :/

tests/wpt/run.sh: line 9: [: ==: unary operator expected
Fixes #5056
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on b80593c Feb 26, 2015

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 26, 2015

merging acgtyrant/servo/patch-1 = b80593c into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 26, 2015

acgtyrant/servo/patch-1 = b80593c merged ok, testing candidate = 3fc2478

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 26, 2015

fast-forwarding master to auto = 3fc2478

bors-servo pushed a commit that referenced this pull request Feb 26, 2015
@bors-servo bors-servo closed this Feb 26, 2015
@bors-servo bors-servo merged commit b80593c into servo:master Feb 26, 2015
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.