Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WA for borders ref test #5087

Merged
merged 1 commit into from Feb 27, 2015
Merged

Conversation

@bjwbell
Copy link
Contributor

bjwbell commented Feb 27, 2015

The borders_a.html ref test had a WA to avoid displaying a spurious
black pixel at (0,0). Details are at
#2879

The WA can be removed since the bug is no longer reproducible.

The borders_a.html ref test had a WA to avoid displaying a spurious
black pixel at (0,0). Details are at
#2879

The WA can be removed since the bug is no longer reproducible.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 27, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4124

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link

jdm commented on 0f40780 Feb 27, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 0f40780 Feb 27, 2015

saw approval from jdm
at bjwbell@0f40780

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 27, 2015

merging bjwbell/servo/remove-borders-test-wa = 0f40780 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 27, 2015

bjwbell/servo/remove-borders-test-wa = 0f40780 merged ok, testing candidate = e4d607e

This comment has been minimized.

Copy link
Contributor

bors-servo replied Feb 27, 2015

fast-forwarding master to auto = e4d607e

bors-servo pushed a commit that referenced this pull request Feb 27, 2015
The borders_a.html ref test had a WA to avoid displaying a spurious
black pixel at (0,0). Details are at
#2879

The WA can be removed since the bug is no longer reproducible.
@bors-servo bors-servo closed this Feb 27, 2015
@bors-servo bors-servo merged commit 0f40780 into servo:master Feb 27, 2015
1 check passed
1 check passed
default all tests passed
@bjwbell bjwbell deleted the bjwbell:remove-borders-test-wa branch Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.