Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRFC: Fix duplicate root html #510
Closed
Conversation
|
I think this is complicating the issue far more than it needs to. Instead, I think we should check whether the default node we create has any children before returning a result, and return the node's firstChild if it exists (after detaching it from its parent). Otherwise, we can return the default node instead. |
|
Also will need a rebase. |
|
Thanks for the comments! I'm trying to find time to finish this. |
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Merged all the projects under the Cargo workspace This will speed up the builds a little. Also added CI testing for the sample/replay binaries. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/510) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jjjjw commentedJun 9, 2013
This should not be merged because it still has some fail.
In grappling with #343 I started to pull apart the document element and the document node. I got stuck because now we have two code paths that want to create a document node; once when we create the window and the document, and then again when we create all the nodes in the tree. I am currently wondering which is the better way, maybe neither, and how to make one path clearly responsible. Thinking to set the 'Document' on a hypothetical 'DocumentNode' and then create the document along with the tree.