Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace borrow with borrow_for_gc_trace in JSTraceable::trace (Issue #47... #5131

Merged
merged 1 commit into from Mar 3, 2015

Conversation

@aweinstock314
Copy link
Contributor

aweinstock314 commented Mar 3, 2015

...78).

@highfive
Copy link

highfive commented Mar 3, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 3, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4161

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Mar 3, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm

This comment has been minimized.

Copy link

jdm commented on bcc27d9 Mar 3, 2015

r+

@jdm jdm added the S-awaiting-merge label Mar 3, 2015
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on bcc27d9 Mar 3, 2015

saw approval from jdm
at aweinstock314@bcc27d9

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 3, 2015

merging aweinstock314/servo/master = bcc27d9 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 3, 2015

aweinstock314/servo/master = bcc27d9 merged ok, testing candidate = 417a932

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 3, 2015

fast-forwarding master to auto = 417a932

bors-servo pushed a commit that referenced this pull request Mar 3, 2015
...78).
@bors-servo bors-servo closed this Mar 3, 2015
@bors-servo bors-servo merged commit bcc27d9 into servo:master Mar 3, 2015
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.