Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace borrow with borrow_for_gc_trace in JSTraceable::trace (Issue #47... #5131
Conversation
highfive
commented
Mar 3, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
Mar 3, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4161 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Mar 3, 2015
This comment has been minimized.
This comment has been minimized.
jdm
commented on bcc27d9
Mar 3, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging aweinstock314/servo/master = bcc27d9 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 417a932 |
bcc27d9
into
servo:master
aweinstock314 commentedMar 3, 2015
...78).