Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-platform-tests. #5146

Merged
merged 1 commit into from Mar 17, 2015
Merged

Update web-platform-tests. #5146

merged 1 commit into from Mar 17, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 4, 2015

Review on Reviewable

@highfive
Copy link

highfive commented Mar 4, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 4, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4181

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Mar 5, 2015
@Ms2ger Ms2ger force-pushed the Ms2ger:wpt_20150304 branch from 6572662 to 7de5f57 Mar 5, 2015
bors-servo pushed a commit that referenced this pull request Mar 5, 2015
@jdm jdm added the S-awaiting-merge label Mar 5, 2015
bors-servo pushed a commit that referenced this pull request Mar 5, 2015
@Ms2ger Ms2ger force-pushed the Ms2ger:wpt_20150304 branch from 7de5f57 to 7430603 Mar 5, 2015
bors-servo pushed a commit that referenced this pull request Mar 5, 2015
bors-servo pushed a commit that referenced this pull request Mar 6, 2015
@jdm
Copy link
Member

jdm commented Mar 6, 2015

Note - reftests are the only things failing, and only on linux, so I suspect one of the wptrunner changes.

@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Mar 6, 2015
@jdm
Copy link
Member

jdm commented Mar 6, 2015

I was wrong, we are still hitting this on other PRs.

bors-servo pushed a commit that referenced this pull request Mar 6, 2015
@jdm
Copy link
Member

jdm commented Mar 7, 2015

Wow - our "passing" reftests right now are hitting this: http://build.servo.org/builders/linux2/builds/951/steps/shell_1/logs/stdio . Maybe the wptrunner update just better detects these problems now?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 8, 2015

That should be fixed by servo/saltfs#21.

@Ms2ger Ms2ger force-pushed the Ms2ger:wpt_20150304 branch from 7430603 to 0307891 Mar 8, 2015
bors-servo pushed a commit that referenced this pull request Mar 8, 2015
@Ms2ger Ms2ger force-pushed the Ms2ger:wpt_20150304 branch from 0307891 to 4deb2d1 Mar 17, 2015
bors-servo pushed a commit that referenced this pull request Mar 17, 2015
@jdm
Copy link
Member

jdm commented Mar 17, 2015

/webstorage/event_local_key.html
--------------------------------
NOTRUN key property test of local event
/webstorage/event_local_newvalue.html
-------------------------------------
NOTRUN newValue property test of local event
/webstorage/event_local_storagearea.html
----------------------------------------
NOTRUN storageArea property test of local event
/webstorage/event_local_oldvalue.html
-------------------------------------
NOTRUN oldValue property test of local event
/webstorage/event_local_url.html
--------------------------------
NOTRUN url property test of local event
@Ms2ger Ms2ger force-pushed the Ms2ger:wpt_20150304 branch from 4deb2d1 to a8553c3 Mar 17, 2015
@Ms2ger

This comment has been minimized.

Copy link
Owner Author

Ms2ger commented on a8553c3 Mar 17, 2015

r=jgraham

This comment has been minimized.

Copy link
Owner Author

Ms2ger replied Mar 17, 2015

r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on a8553c3 Mar 17, 2015

saw approval from jgraham, Manishearth
at Ms2ger@a8553c3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 17, 2015

merging Ms2ger/servo/wpt_20150304 = a8553c3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 17, 2015

Ms2ger/servo/wpt_20150304 = a8553c3 merged ok, testing candidate = ff39ae6

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 17, 2015

fast-forwarding master to auto = ff39ae6

bors-servo pushed a commit that referenced this pull request Mar 17, 2015
@bors-servo bors-servo closed this Mar 17, 2015
@bors-servo bors-servo merged commit a8553c3 into servo:master Mar 17, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default all tests passed
@Ms2ger Ms2ger deleted the Ms2ger:wpt_20150304 branch Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.