Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport opt-in async network events #5156
Conversation
highfive
commented
Mar 5, 2015
|
@pcwalton Here's a smattering of relevant code to be evaluated for sandboxing concerns: |
|
Huh, this never got a Critic review. I guess the review that's happening in #5197 can serve the same purpose. |
|
I'm not sure about passing closures cross-process, in general, since closures aren't Encodable. But perhaps a code pointer plus an Encodable set of data that works like a closure would work. |
hoppipolla-critic-bot
commented
Mar 31, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4448 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@pcwalton has agreed to take this one. |
|
Overall this looks pretty solid, but I'm not a big XHR expert. I'd like someone who's more intimately familiar with the XHR code, maybe @Manishearth, to take another look. |
|
I'll have a look tomorrow. |
|
@jdm r=me with rebase |
|
@bors-servo: r=pcwalton,Manishearth |
|
|
This implements a framework for opting in to receiving network events asynchronously. It also converts XMLHttpRequest to use them, and paves the way for better support for synchronous XHR using on-demand, targeted event loops instead of spinning the global event loop. This gives us complete feature parity with the existing XHR implementation, using fewer threads than before in the async case. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5156) <!-- Reviewable:end -->
jdm commentedMar 5, 2015
This implements a framework for opting in to receiving network events asynchronously. It also converts XMLHttpRequest to use them, and paves the way for better support for synchronous XHR using on-demand, targeted event loops instead of spinning the global event loop. This gives us complete feature parity with the existing XHR implementation, using fewer threads than before in the async case.