Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updecouple script from compositor, route through layout #517
+616
−541
Conversation
|
r? @pcwalton some of the code in compositing/mod.rs was moved around, which makes the commit changes a bit difficult to follow |
added 4 commits
Jun 13, 2013
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/compositing/mod.rs in b5dac3f
Jun 17, 2013
|
The comment here is incorrect as |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/compositing/mod.rs in b5dac3f
Jun 17, 2013
|
The name |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/engine.rs in 496069d
Jun 17, 2013
|
If this is no longer needed, just delete the whole Drop implementation. |
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
communicate via layout refactor channel wrappers from *Task --> *Chan
|
The rust-glut pointer is bad: |
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
communicate via layout refactor channel wrappers from *Task --> *Chan
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
communicate via layout refactor channel wrappers from *Task --> *Chan
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
communicate via layout refactor channel wrappers from *Task --> *Chan
…AttachCompositorMsg added to render_task::Msg updated to reflect comments
This comment has been minimized.
This comment has been minimized.
metajack
commented on 577a410
Jun 17, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging tkuehn/servo/master = 577a410 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = d61c455 |
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
communicate via layout refactor channel wrappers from *Task --> *Chan
bors-servo
merged commit 577a410
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Address review comments on the Performance Timeline tests.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Support for non-stacking-context scrolling areas When we encounter a stacking context which scrolls its contents, we treat it as a special non-stacking-context scrolling area. All scrolling areas with the same servo scroll root id will be scrolled in tandem. Later changes will give these fake stacking contexts their own display item. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/517) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tikue commentedJun 14, 2013
communicate via layout
refactor channel wrappers from *Task --> *Chan