Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch to GPU rendering #518
Merged
Conversation
| @@ -75,6 +78,7 @@ pub impl<'self> RenderContext<'self> { | |||
| self.canvas.rect.origin.y as AzFloat), | |||
| Size2D(self.canvas.rect.size.width as AzFloat, | |||
| self.canvas.rect.size.height as AzFloat)); | |||
| self.canvas.draw_target.make_current(); | |||
This comment has been minimized.
This comment has been minimized.
pcwalton
Jun 14, 2013
Contributor
Having to call this all over the place is unfortunate. Can we encapsulate this somehow? This strikes me as a memory safety issue.
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 282288d
Jun 14, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging metajack/servo/gpu-rendering = 282288d into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 93eea6b |
bors-servo
pushed a commit
that referenced
this pull request
Jun 14, 2013
This uses Skia GL to render to offscreen FBOs and then passes the resulting textures directly to the compositor. It depends on servo/rust-azure#26 and servo/skia#14 r? @pcwalton
bors-servo
merged commit 282288d
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
fixing small typos in DeviceLight_tests.js
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Remove the unused StackingContext has_stacking_contexts field It seems that this field has been unused since the switch to WR2. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/518) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJun 14, 2013
This uses Skia GL to render to offscreen FBOs and then passes the resulting textures directly to the compositor.
It depends on servo/rust-azure#26 and servo/skia#14
r? @pcwalton