Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async fetching of extenal script sources via interruptible parsing. #5197

Closed
wants to merge 14 commits into from

Warning fixes.

  • Loading branch information
jdm committed Mar 5, 2015
commit 248a2037f6619f04a48f1bf0478240fc78491ff0
@@ -946,7 +946,7 @@ impl<'a> PrivateXMLHttpRequestHelpers for JSRef<'a, XMLHttpRequest> {
timeout_target.send(ScriptMsg::RunnableMsg(box XHRTimeout {
xhr: xhr,
gen_id: gen_id,
}));
})).unwrap();
},
Err(_) => {
// This occurs if xhr.timeout (the sender) goes out of scope (i.e, xhr went out of scope)
@@ -18,7 +18,7 @@ impl<T: AsyncResponseListener + PreInvoke + Send> AsyncResponseTarget for Networ
self.script_chan.send(ScriptMsg::RunnableMsg(box ListenerRunnable {
context: self.context.clone(),
listener: listener,
}));
})).unwrap();
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.