Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor the compositing interface to use messages instead of callbacks. #520
+225
−280
Conversation
This will enable compositing to be cleaned up drastically and is necessary for proper integration with the new scheduler.
This comment has been minimized.
This comment has been minimized.
metajack
commented on f1c24a9
Jun 17, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging pcwalton/servo/windowing-messages = f1c24a9 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors-servo
pushed a commit
that referenced
this pull request
Jun 17, 2013
|
@pcwalton: build logs: https://gist.github.com/metajack/5799081 |
|
This needs a rebase. |
caitp
pushed a commit
to caitp/servo
that referenced
this pull request
Apr 27, 2014
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add tests for ArrayBuffer
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Implement HeapSizeOf for ColorF and GradientStop. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/520) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…allbacks (from eschweic:windowing-messages); r=metajack Replaces servo/servo#520 so we don't have to go through the pain of rebasing it. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: 09acdcc4ec5cb504f17b3d0e5d655b5ccc8213ae UltraBlame original commit: bf014a4d677ca3377c386fcc4ed4add42c7987d2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2019
…allbacks (from eschweic:windowing-messages); r=metajack Replaces servo/servo#520 so we don't have to go through the pain of rebasing it. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: 09acdcc4ec5cb504f17b3d0e5d655b5ccc8213ae UltraBlame original commit: bf014a4d677ca3377c386fcc4ed4add42c7987d2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…allbacks (from eschweic:windowing-messages); r=metajack Replaces servo/servo#520 so we don't have to go through the pain of rebasing it. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: 09acdcc4ec5cb504f17b3d0e5d655b5ccc8213ae UltraBlame original commit: bf014a4d677ca3377c386fcc4ed4add42c7987d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJun 15, 2013
This will enable compositing to be cleaned up drastically and is necessary
for proper integration with the new scheduler.
r? @metajack