Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment variable to override cache-dir #5200

Closed
wants to merge 1 commit into from

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 11, 2015

This will be set in servo/saltfs to prevent our buildbot builders from re-downloading the build tools for every build.

r? @larsbergstrom or @metajack or @Manishearth

This will be set in servo/saltfs to prevent our buildbot builders from
re-downloading the build tools for every build.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 11, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4240

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@SimonSapin
Copy link
Member

SimonSapin commented Mar 11, 2015

Can’t the builders have their own .servobuild config?

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Mar 11, 2015

Can’t the builders have their own .servobuild config?

Yes, that could work too. I'll see if there's a simple way to tell buildbot to copy a file from saltfs into the working dir.

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Mar 11, 2015

mbrubeck/saltfs@323d3c4 is an alternate fix that adds a servobuild file to the buildbot slaves, though I haven't tested it and I'm not sure if it's the best way to do that.

@larsbergstrom

This comment has been minimized.

Copy link

larsbergstrom commented on 4641640 Mar 19, 2015

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 4641640 Mar 19, 2015

saw approval from larsbergstrom
at mbrubeck@4641640

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

merging mbrubeck/servo/cache-dir = 4641640 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

mbrubeck/servo/cache-dir = 4641640 merged ok, testing candidate = 82f70c5

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

fast-forwarding master to auto = 82f70c5

bors-servo pushed a commit that referenced this pull request Mar 19, 2015
This will be set in servo/saltfs to prevent our buildbot builders from re-downloading the build tools for every build.

r? @larsbergstrom or @metajack or @Manishearth
@bors-servo bors-servo closed this Mar 19, 2015
@mbrubeck mbrubeck deleted the mbrubeck:cache-dir branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.