Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd an environment variable to override cache-dir #5200
Conversation
This will be set in servo/saltfs to prevent our buildbot builders from re-downloading the build tools for every build.
hoppipolla-critic-bot
commented
Mar 11, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4240 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Can’t the builders have their own |
Yes, that could work too. I'll see if there's a simple way to tell buildbot to copy a file from saltfs into the working dir. |
|
mbrubeck/saltfs@323d3c4 is an alternate fix that adds a servobuild file to the buildbot slaves, though I haven't tested it and I'm not sure if it's the best way to do that. |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on 4641640
Mar 19, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/cache-dir = 4641640 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 82f70c5 |
This will be set in servo/saltfs to prevent our buildbot builders from re-downloading the build tools for every build. r? @larsbergstrom or @metajack or @Manishearth
mbrubeck commentedMar 11, 2015
This will be set in servo/saltfs to prevent our buildbot builders from re-downloading the build tools for every build.
r? @larsbergstrom or @metajack or @Manishearth