Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rendering code #523

Merged
merged 5 commits into from Jun 20, 2013
Merged

Refactor rendering code #523

merged 5 commits into from Jun 20, 2013

Conversation

@metajack
Copy link
Contributor

metajack commented Jun 17, 2013

This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton

metajack added 4 commits Jun 17, 2013
This removes the task per tile rendering and instead renders tiles
serially. This also unwraps the rendering into a single function so that it's
much clearer.
@pcwalton

This comment has been minimized.

Copy link

pcwalton commented on a9e1354 Jun 19, 2013

r+

This comment has been minimized.

Copy link
Owner Author

metajack replied Jun 19, 2013

@bors: retry

This comment has been minimized.

Copy link
Owner Author

metajack replied Jun 19, 2013

@bors: retry

This comment has been minimized.

Copy link
Owner Author

metajack replied Jun 19, 2013

@bors: retry

This comment has been minimized.

Copy link
Owner Author

metajack replied Jun 19, 2013

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on a9e1354 Jun 19, 2013

saw approval from pcwalton
at metajack@a9e1354

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

merging metajack/servo/gpu-profiling = a9e1354 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

metajack/servo/gpu-profiling = a9e1354 merged ok, testing candidate = 9182e04

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

saw approval from pcwalton
at metajack@a9e1354

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

saw approval from pcwalton
at metajack@a9e1354

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

merging metajack/servo/gpu-profiling = a9e1354 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 19, 2013

metajack/servo/gpu-profiling = a9e1354 merged ok, testing candidate = e5e5687

This comment has been minimized.

bors-servo pushed a commit that referenced this pull request Jun 19, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
bors-servo pushed a commit that referenced this pull request Jun 19, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
bors-servo pushed a commit that referenced this pull request Jun 19, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
bors-servo pushed a commit that referenced this pull request Jun 19, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
bors-servo pushed a commit that referenced this pull request Jun 19, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
@metajack

This comment has been minimized.

Copy link
Owner Author

metajack commented on 73ed0c6 Jun 20, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 73ed0c6 Jun 20, 2013

saw approval from metajack
at metajack@73ed0c6

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 20, 2013

merging metajack/servo/gpu-profiling = 73ed0c6 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 20, 2013

metajack/servo/gpu-profiling = 73ed0c6 merged ok, testing candidate = 63a7466

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jun 20, 2013

fast-forwarding master to auto = 63a7466

bors-servo pushed a commit that referenced this pull request Jun 20, 2013
This makes the rendering code serial instead of parallel since it now just dispatches commands to the GPU.

It also adds some more profiling data.

r? @pcwalton
@bors-servo bors-servo merged commit 73ed0c6 into servo:master Jun 20, 2013
1 check passed
1 check passed
default all tests passed
@metajack metajack deleted the metajack:gpu-profiling branch Jun 20, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Update the test for setting document.title to the empty string; r=foolip
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Remove ResourceList structure and usage.

Previously, a resource list would be built at the start of the
frame. This would allow glyphs missing from the texture cache
to be rasterized.

However, sometimes (e.g. with subpixel antialiasing) it's not possible
to know right at the start of the frame exactly what needs to be
rasterized yet.

Instead, we now allow the resource cache to add requests during
the prepare_prim_for_render() stage. Primitives that request
resources are marked as needing a resolve operation. This allows
primitives that request resources to update their UV coords etc
before batching occurs (since texture IDs for resources must be
known before batching can occur).

This also lays most of the groundwork for running the resource
cache rasterizer as a separate thread in the future. This will be
used to ensure that if too many glyphs are requested in one frame,
WR can continue running without blocking, using older glyphs and
then re-render the scene when newer, high resolution glyphs are
available.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/523)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.