Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake IOCompositor only respond to the first Quit event. #5245
Conversation
hoppipolla-critic-bot
commented
Mar 17, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4280 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @glennw |
This comment has been minimized.
This comment has been minimized.
glennw
commented on 2b10f6e
Mar 17, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from glennw |
This comment has been minimized.
This comment has been minimized.
|
merging nnethercote/servo/only-one-quit-event = 2b10f6e into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 2281bca |
This fixes #5234, in that the huge memory spike disappears. It still takes ~15 seconds for the window to actually disappear after that first `Quit` event is received by the IOCompositor. Maybe that's a pre-existing problem. There may be better ways to do this, like handling it on the sending side (i.e. within glutin) instead of the receiving side. I just did it this way because it seemed like the easiest thing.
2b10f6e
into
servo:master
nnethercote commentedMar 17, 2015
This fixes #5234, in that the huge memory spike disappears. It still takes ~15 seconds for the window to actually disappear after that first
Quitevent is received by the IOCompositor. Maybe that's a pre-existing problem.There may be better ways to do this, like handling it on the sending side (i.e. within glutin) instead of the receiving side. I just did it this way because it seemed like the easiest thing.