Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an LRU cache and use it for fonts and font groups #525

Merged
merged 1 commit into from Jun 20, 2013

Conversation

@sethfowler
Copy link
Contributor

sethfowler commented Jun 17, 2013

We hit this cache a lot.

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 17, 2013

Argh, I should repush. Didn't meant to pull in that other branch.

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 17, 2013

Fixed.

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 18, 2013

This resolves #178 (E), and #196.

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 18, 2013

Almost forgot, this fixes #203 as well. I'll close all these issues once the PR is merged. Fixing review comments now.

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 19, 2013

I am going to create a separate pull request that has much more substantial changes to cache.rs. I'd prefer to defer the change to clone() to that PR, because to do it correctly really involves making broader changes that I don't want to do in this PR.

@metajack

This comment has been minimized.

Copy link

metajack commented on 318b2cf Jun 20, 2013

r+

@sethfowler
Copy link
Contributor Author

sethfowler commented Jun 20, 2013

Thanks, Jack.

sethfowler added a commit that referenced this pull request Jun 20, 2013
Add an LRU cache and use it for fonts and font groups
@sethfowler sethfowler merged commit 68aee00 into servo:master Jun 20, 2013
@sethfowler sethfowler deleted the sethfowler:font-cache branch Jun 20, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Start merging new-Blob.html and Blob-constructor.html; r=zcorpan
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.