Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in gonk port #5272

Closed
wants to merge 1 commit into from
Closed

Conversation

@michaelwu
Copy link
Contributor

michaelwu commented Mar 19, 2015

This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 19, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4299

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack

This comment has been minimized.

Copy link

metajack commented on 67666c4 Mar 19, 2015

r+

This comment has been minimized.

Copy link

larsbergstrom replied Mar 19, 2015

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 67666c4 Mar 19, 2015

saw approval from metajack
at michaelwu@67666c4

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

merging michaelwu/servo/fix-gonk-warnings = 67666c4 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

michaelwu/servo/fix-gonk-warnings = 67666c4 merged ok, testing candidate = c0dcb58

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

saw approval from metajack
at michaelwu@67666c4

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

merging michaelwu/servo/fix-gonk-warnings = 67666c4 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

michaelwu/servo/fix-gonk-warnings = 67666c4 merged ok, testing candidate = 8906d48

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 19, 2015

fast-forwarding master to auto = 8906d48

bors-servo pushed a commit that referenced this pull request Mar 19, 2015
This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 19, 2015

Retried because of intermittent failure logged as #5207

bors-servo pushed a commit that referenced this pull request Mar 19, 2015
This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.
@bors-servo bors-servo closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.