Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix warnings in gonk port #5272
Conversation
hoppipolla-critic-bot
commented
Mar 19, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4299 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 67666c4
Mar 19, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
replied
Mar 19, 2015
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging michaelwu/servo/fix-gonk-warnings = 67666c4 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging michaelwu/servo/fix-gonk-warnings = 67666c4 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 8906d48 |
This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.
|
Retried because of intermittent failure logged as #5207 |
This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.
michaelwu commentedMar 19, 2015
This fixes a bunch of warnings in the gonk code. Not all of them, but we're only left with three now.